Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main): do not hang on exit #150

Merged
merged 1 commit into from
Jan 20, 2021
Merged

fix(main): do not hang on exit #150

merged 1 commit into from
Jan 20, 2021

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Jan 20, 2021

There are two fixes here:

  1. As per @TheLostLambda's request, we now have a more predictable close order for the threads. Waiting for one to close before closing the other in main.
  2. Before, in the render method when we had no tabs left, we would send a quit message to the app. This caused a deadlock when we got a render instruction from the pty (eg. when there was some data left in its buffer) while quitting. To fix this, I moved this logic to the close_tab method, and then in the render method if there's no active tab it becomes a no-op.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant