Initial Implementation of the Status Bar as a WASM Plugin #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3nill
reviewed
Jan 12, 2021
Comment on lines
-10
to
+12
| println!("cargo:rerun-if-changed=src/app.rs"); | ||
| println!("cargo:rerun-if-changed=src/cli.rs"); |
There was a problem hiding this comment.
Oh missed that 😅.... Thank You!
|
It is causing panic for me, whenever I try to switch mode with panic message: https://hatebin.com/azoyagyqdi |
Thanks for finding that! The bug was in the plugin code, which is now patched! The updated WASM has been shipped in this repo :) |
|
I didn't take too deep of a look at the code, but on the surface this looks great to me. Fantastic (and quick!!) work :) |
|
Awesome! If it doesn't cause any issues in your testing, I'm happy merging whenever 🙂 |
|
Go ahead :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just knocked out these tasks, which closes #71
I also patched up 23 compiler warnings and clippy lints from main, since I like clean builds!
Here is a demo video of the newly added functionality:
2021-01-12.04-43-18.mp4