-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: move tab to other position #1656
Comments
I'll try to implement this since I think that it shouldn't take too long (or am I wrong?) |
@TornaxO7 Awesome! If you want, you can do it anytime. No need to rush! |
@jaeheonji |
@jaeheonji Is it fine if I'm also trying to refactor a little bit the Screen struct? I'd like to move the tabs attribute to an extra-struct and move some methods of screen as well. |
@jaeheonji I also have another question: Why are you picking up the history of the first entry according to this line? Why not creating a new history for the new client? |
Yes! The context is used for errors. In order to implement this feature, you will need to implement a new action. So you will have to add something new to Context and Action such as
Of course, If you need it you can. However, if there are a lot of refactoring contents, it would be good for a review to make a separate PR.
As far as I know, this is meant to be a multiple session feature. Because multiple sessions share one session with multiple clients. Therefore, in the case of a tab, the history is loaded instead of creating a new one. |
@jaeheonji May I ask you what those slices represent? |
@jaeheonji general question because I'm getting a server error currently xD. What I've done now is adding my actions in
So I'm wondering which steps I'm missing. To sum my steps up:
|
Since the error occurs in I don't know how far you've been working on it, so I'm assuming a few situations.
For example: # custom.yaml
---
template:
direction: Horizontal
parts:
- direction: Vertical
borderless: true
split_size:
Fixed: 1
run:
plugin:
location: "file:target/wasm32-wasi/debug/tab-bar.wasm"
- direction: Vertical
body: true
- direction: Vertical
borderless: true
split_size:
Fixed: 2
run:
plugin:
location: "file:target/wasm32-wasi/debug/status-bar.wasm"
tabs:
- direction: Vertical and start zellij with layout options |
ooof... ok, that should be the reason |
@jaeheonji I'm sorry for the late reply but may I ask you what your intention is with that |
It's okay. I was also busy. My intention is that if you modify the plugin code, in order to test the modified plugin, you have to make a But, unless you modified the plugin, it's not important. |
I haven't modified any plugin yet because I'm bit overhelmed by the plugins where I should start with xD |
Do you have any tips how I can approach this? |
@TornaxO7 Is there an error in the draft code you uploaded? Then, I will get the code and check it out. |
Yes, the draft includes the current code, thank you for willing to try it out :) |
All you need to do is adding the following keybinding: keybinds:
unbind: true
normal:
- action: [MoveTab: Left]
key: [Char: 'H`]
# and the rest of your config |
any progress on this feature?? |
Hi! I'm sorry, but I I don't have the time and motivation at the moment to continue my PR. |
tmux is a mess to config, but this one feature is the sole reason why I still can't switch to zellij. Having un-movable tabs is a total deal-breaker. Is there really no workaround? |
I'm using zellij on a daily basis and I would love to have this feature - "Reorganizing order of tabs I already opened" |
This is my workaround until this feature is implemented I have missed this feature a couple of times when I accidentally have deleted a tab (happened today). It's important for me that the tabs are in the correct order because that's how I've had it in Tmux for 15 years and it's in the muscle memory. When creating a new Tab in Zellij, it ends up to the right of the other tabs and this is how I fix it.
|
Hi. I implemented the feature here. Demo of current implementation:
zellij-tabs-showcase.webmEdit: zellij-tabs-complex-showcase.webm |
The feature was implemented in released in v0.40.1. Use |
Reference #1654
The text was updated successfully, but these errors were encountered: