Change SetJSON to correctly handle pointer args #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with not grabbed `goriakindex` tags when we pass the pointer to SetJSON method. Before this commit the behavior was: - call SetJSON with the pointer to a struct which has `goriakindex` tag. - under the hood, the method determinates kind of passed value as `ptr` and doesn't try to find the field with tag. - data are silently written into a bucket, without a secondary key. In this commit added an extra check on pointer and data passed by pointer handled in the same way as data passed by value. Test case included into the commit.
Shkurpylo
force-pushed
the
setjson_pointer_handling
branch
from
c09a381
to
db851b6
Compare
|
Hey @Shkurpylo, thanks for the great looking PR! This is an unfortunate bug, I'll make a new release with this fix in it right now. |
|
Hey @zegl, glad to help! Thank you for the useful project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with not grabbed
goriakindextags when we pass the pointer to SetJSON method.Before this commit the behavior was:
goriakindextag.ptrand doesn't try to find the field with tag.In this commit added an extra check on pointer and data passed by pointer handled in the same way as data passed by value.
Test case included into the commit.