Add Teddit redirects #353
Add Teddit redirects #353
Conversation
This doesn't redirect rddt.co links, but those work like Bitly and would require a more in-depth solution.
This initial implementation is built around Teddit specifically, and thus may not work with Libreddit. This could be added in the future but for now I'm removing it.
Unsure as to why but for the time being the ".mp4" extension on v.redd.it Teddit links is not part of the formatted link. Looking into this.
|
This doesn't work for libreddit? What's the missing URL? |
|
It could be made to work with libreddit, but would require some changes. If you look at commit 98ce4ed, you see that the i.redd.it and v.redd.it redirects use Teddit-specific URL paths. libreddit uses different paths for video and images. If we wanted to support both, we could do one of two things:
I went with Teddit because that's what I personally use, but I would be willing to do further work to support both projects. |
|
I see, this requires more work. libreddit (or teddit) might accept a request to standardize on the image/video location. It appears that Teddit has a more robust media implementation, so I think this MR should be good to merge. |
|
Thanks @FIGBERT! I've decided to not support v.redd.it and i.redd.it for now, due to some issues described in the code's comments. I've also talked a bit about it here: libreddit/libreddit#371 (comment) |
Closes #306. Doesn't include Libreddit support, as i.redd.it and v.redd.it links include Teddit-specific logic.