Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux scripts: Respect $CARGO_TARGET_DIR #13830

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

p00f
Copy link
Contributor

@p00f p00f commented Jul 4, 2024

https://doc.rust-lang.org/cargo/reference/environment-variables.html

Some people (myself included) set this variable to have a single directory to clean up (or whatever reason one might have for having a single target directory). This changes the linux scripts to respect that

Release Notes:

Optionally, include screenshots / media showcasing your addition that can be included in the release notes.

Or...

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 4, 2024
@maxdeviant maxdeviant changed the title linux scripts: respect $CARGO_TARGET_DIR linux scripts: Respect $CARGO_TARGET_DIR Jul 4, 2024
@p00f
Copy link
Contributor Author

p00f commented Jul 4, 2024

Maybe the "respect" wording is wrong - cargo will write to CARGO_TARGET_DIR but the shell commands don't know that (yet)

Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@SomeoneToIgnore SomeoneToIgnore self-assigned this Jul 5, 2024
@SomeoneToIgnore SomeoneToIgnore merged commit 1260b52 into zed-industries:main Jul 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants