[chore] Code linter findings for internal/aws (open-telemetry#24946)

preallocate slices do not assign a boolean if it is reassigned right after
zdelagrange · Aug 17, 2023 · fbed147 · fbed147
1 parent 58bcb0c
commit fbed147
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/internal/aws/k8s/k8sclient/clientset.go b/internal/aws/k8s/k8sclient/clientset.go
@@ -107,9 +107,9 @@ func InitSyncPollTimeout(pollTimeout time.Duration) Option {
 }
 
 func getStringifiedOptions(options ...Option) string {
- var opts []string
- for _, option := range options {
- opts = append(opts, option.name)
+ opts := make([]string, len(options))
+ for i, option := range options {
+ opts[i] = option.name
  }
 
  sort.Strings(opts)

diff --git a/internal/aws/metrics/metric_calculator.go b/internal/aws/metrics/metric_calculator.go
@@ -61,7 +61,7 @@ func (rm *MetricCalculator) Calculate(mKey Key, value interface{}, timestamp tim
  cacheStore := rm.cache
 
  var result interface{}
- done := false
+ var done bool
 
  rm.lock.Lock()
  defer rm.lock.Unlock()
@@ -92,7 +92,7 @@ type Key struct {
 }
 
 func NewKey(metricMetadata interface{}, labels map[string]string) Key {
- var kvs []attribute.KeyValue
+ kvs := make([]attribute.KeyValue, 0, len(labels))
  var sortable attribute.Sortable
  for k, v := range labels {
  kvs = append(kvs, attribute.String(k, v))