[exporter/elasticsearch] Enable errcheck in elasticsearch exporter (o…

…pen-telemetry#14945) * remove warning Signed-off-by: jian.tan <[email protected]> * fix TestExporter_PushTraceRecord Flaky test * fix lint for es exporter Signed-off-by: Jared Tan <[email protected]> * revert Signed-off-by: Jared Tan <[email protected]> * fix lint Signed-off-by: Jared Tan <[email protected]> Signed-off-by: jian.tan <[email protected]> Signed-off-by: Jared Tan <[email protected]>
zdelagrange · Oct 14, 2022 · fa927a6 · fa927a6
1 parent 697cac1
commit fa927a6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/exporter/elasticsearchexporter/logs_exporter.go b/exporter/elasticsearchexporter/logs_exporter.go
@@ -14,7 +14,6 @@
 
 // Package elasticsearchexporter contains an opentelemetry-collector exporter
 // for Elasticsearch.
-// nolint:errcheck
 package elasticsearchexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter"
 
 import (

diff --git a/exporter/elasticsearchexporter/trace_exporter.go b/exporter/elasticsearchexporter/trace_exporter.go
@@ -14,7 +14,6 @@
 
 // Package elasticsearchexporter contains an opentelemetry-collector exporter
 // for Elasticsearch.
-// nolint:errcheck
 package elasticsearchexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter"
 
 import (

diff --git a/exporter/elasticsearchexporter/traces_exporter_test.go b/exporter/elasticsearchexporter/traces_exporter_test.go
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// nolint:errcheck
 package elasticsearchexporter
 
 import (
@@ -313,7 +312,9 @@ func newTestTracesExporter(t *testing.T, url string, fns ...func(*Config)) *elas
  exporter, err := newTracesExporter(zaptest.NewLogger(t), withTestTracesExporterConfig(fns...)(url))
  require.NoError(t, err)
 
- t.Cleanup(func() { exporter.Shutdown(context.TODO()) })
+ t.Cleanup(func() {
+ require.NoError(t, exporter.Shutdown(context.TODO()))
+ })
  return exporter
 }