[exporter/signalfx] Change default timeout to 10 seconds (open-teleme…

…try#29436) Change the default timeout from 5s to 10s Signed-off-by: Dani Louca <[email protected]>
zdelagrange · Nov 22, 2023 · cca6b87 · cca6b87
1 parent a0e6491
commit cca6b87
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/.chloggen/sfx-http-timeout.yaml b/.chloggen/sfx-http-timeout.yaml
@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: signalfxexporter
+
+# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: change default timeout to 10 seconds
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [29436]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []
diff --git a/exporter/signalfxexporter/README.md b/exporter/signalfxexporter/README.md
@@ -84,7 +84,7 @@ The following configuration options can also be configured:
 - `disable_default_translation_rules` (default = `false`): Disable default translation
  of the OTel metrics to a SignalFx compatible format. The default translation rules are
  defined in `translation/constants.go`.
-- `timeout` (default = 5s): Amount of time to wait for a send operation to
+- `timeout` (default = 10s): Amount of time to wait for a send operation to
  complete.
 - `headers` (no default): Headers to pass in the payload.
 - `max_idle_conns` (default = 100): The maximum idle HTTP connections the client can keep open.

diff --git a/exporter/signalfxexporter/config_test.go b/exporter/signalfxexporter/config_test.go
@@ -48,7 +48,7 @@ func TestLoadConfig(t *testing.T) {
  AccessToken: "testToken",
  Realm: "ap0",
  HTTPClientSettings: confighttp.HTTPClientSettings{
- Timeout: 5 * time.Second,
+ Timeout: 10 * time.Second,
  Headers: nil,
  MaxIdleConns: &hundred,
  MaxIdleConnsPerHost: &hundred,

diff --git a/exporter/signalfxexporter/factory.go b/exporter/signalfxexporter/factory.go
@@ -22,7 +22,7 @@ import (
 )
 
 const (
- defaultHTTPTimeout = time.Second * 5
+ defaultHTTPTimeout = time.Second * 10
  defaultMaxConns = 100
 
  defaultDimMaxBuffered = 10000