[receiver/saphana] Fix units on saphana licenses metrics (open-teleme…

…try#14695) Fix issue with units for two saphana metrics.
zdelagrange · Oct 5, 2022 · ae26015 · ae26015
1 parent 8ad476c
commit ae26015
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 8 deletions.
diff --git a/.chloggen/saphana-fix-units.yaml b/.chloggen/saphana-fix-units.yaml
@@ -0,0 +1,11 @@
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: saphanareceiver
+
+# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Fix incorrect use of units for saphana licenses metrics
+
+# One or more tracking issues related to the change
+issues: [10565]
diff --git a/receiver/saphanareceiver/documentation.md b/receiver/saphanareceiver/documentation.md
@@ -22,8 +22,8 @@ These are the metrics available for this scraper.
 | **saphana.instance.memory.shared.allocated** | The shared memory size of SAP HANA processes. | By | Sum(Int) | <ul> </ul> |
 | **saphana.instance.memory.used.peak** | The peak memory from the memory pool used by SAP HANA processes since the instance started (this is a sample-based value). | By | Sum(Int) | <ul> </ul> |
 | **saphana.license.expiration.time** | The amount of time remaining before license expiration. | s | Gauge(Int) | <ul> <li>system</li> <li>product</li> </ul> |
-| **saphana.license.limit** | The allowed product usage as specified by the license (for example, main memory). | 1 | Sum(Int) | <ul> <li>system</li> <li>product</li> </ul> |
-| **saphana.license.peak** | The peak product usage value during last 13 months, measured periodically. | 1 | Sum(Int) | <ul> <li>system</li> <li>product</li> </ul> |
+| **saphana.license.limit** | The allowed product usage as specified by the license (for example, main memory). | {licenses} | Sum(Int) | <ul> <li>system</li> <li>product</li> </ul> |
+| **saphana.license.peak** | The peak product usage value during last 13 months, measured periodically. | {licenses} | Sum(Int) | <ul> <li>system</li> <li>product</li> </ul> |
 | **saphana.network.request.average_time** | The average response time calculated over recent requests | ms | Gauge(Double) | <ul> </ul> |
 | **saphana.network.request.count** | The number of active and pending service requests. | {requests} | Sum(Int) | <ul> <li>active_pending_request_state</li> </ul> |
 | **saphana.network.request.finished.count** | The number of service requests that have completed. | {requests} | Sum(Int) | <ul> <li>internal_external_request_type</li> </ul> |

diff --git a/receiver/saphanareceiver/internal/metadata/generated_metrics.go b/receiver/saphanareceiver/internal/metadata/generated_metrics.go
diff --git a/receiver/saphanareceiver/metadata.yaml b/receiver/saphanareceiver/metadata.yaml
@@ -266,7 +266,7 @@ metrics:
  enabled: true
  saphana.license.limit:
  description: The allowed product usage as specified by the license (for example, main memory).
- unit: '1'
+ unit: '{licenses}'
  sum:
  monotonic: false
  aggregation: cumulative
@@ -276,7 +276,7 @@ metrics:
  enabled: true
  saphana.license.peak:
  description: The peak product usage value during last 13 months, measured periodically.
- unit: '1'
+ unit: '{licenses}'
  sum:
  monotonic: false
  aggregation: cumulative

diff --git a/receiver/saphanareceiver/testdata/expected_metrics/full.json b/receiver/saphanareceiver/testdata/expected_metrics/full.json
@@ -3289,7 +3289,7 @@
  }
  ]
  },
- "unit": "1"
+ "unit": "{licenses}"
  },
  {
  "description": "The peak product usage value during last 13 months, measured periodically.",
@@ -3337,7 +3337,7 @@
  }
  ]
  },
- "unit": "1"
+ "unit": "{licenses}"
  },
  {
  "description": "The average amount of time consumed replicating a log.",