Skip to content

Commit

Permalink
[exporter/loadbalancer] unexport MetricsViews function (open-teleme…
Browse files Browse the repository at this point in the history
…try#26992)

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#26304

Signed-off-by: Jared Tan <[email protected]>
  • Loading branch information
JaredTan95 committed Sep 19, 2023
1 parent 6d00884 commit 4496b8b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion cmd/checkapi/allowlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ exporter/dynatraceexporter
exporter/f5cloudexporter
exporter/kafkaexporter
exporter/kineticaexporter
exporter/loadbalancingexporter
exporter/logzioexporter
exporter/lokiexporter
exporter/pulsarexporter
Expand Down
2 changes: 1 addition & 1 deletion exporter/loadbalancingexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (

// NewFactory creates a factory for the exporter.
func NewFactory() exporter.Factory {
_ = view.Register(MetricViews()...)
_ = view.Register(metricViews()...)

return exporter.NewFactory(
metadata.Type,
Expand Down
4 changes: 2 additions & 2 deletions exporter/loadbalancingexporter/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ var (
successFalseMutator = tag.Upsert(tag.MustNewKey("success"), "false")
)

// MetricViews return the metrics views according to given telemetry level.
func MetricViews() []*view.View {
// metricViews return the metrics views according to given telemetry level.
func metricViews() []*view.View {
return []*view.View{
{
Name: mNumResolutions.Name(),
Expand Down
2 changes: 1 addition & 1 deletion exporter/loadbalancingexporter/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestProcessorMetrics(t *testing.T) {
"loadbalancer_backend_latency",
}

views := MetricViews()
views := metricViews()
for i, viewName := range expectedViewNames {
assert.Equal(t, viewName, views[i].Name)
}
Expand Down

0 comments on commit 4496b8b

Please sign in to comment.