[chore] testbed: re-add missing names in perfTestDataProvider metrics (…

…open-telemetry#29893) **Description:** These changes add back names to metrics generated by the `perfTestDataProvider` that were mistakenly removed with open-telemetry@063a71a. They also include no longer skipping a carbon test with failures [caused by empty names](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/ed85d1416292601f78b8310601ec556dd6df0a6c/exporter/carbonexporter/metricdata_to_plaintext.go#L84). Co-authored-by: Andrzej Stencel <[email protected]>
zdelagrange · Jan 10, 2024 · 3a1412a · 3a1412a
1 parent 178e315
commit 3a1412a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/testbed/testbed/data_providers.go b/testbed/testbed/data_providers.go
@@ -104,6 +104,7 @@ func (dp *perfTestDataProvider) GenerateMetrics() (pmetric.Metrics, bool) {
 
  for i := 0; i < dp.options.ItemsPerBatch; i++ {
  metric := metrics.AppendEmpty()
+ metric.SetName("load_generator_" + strconv.Itoa(i))
  metric.SetDescription("Load Generator Counter #" + strconv.Itoa(i))
  metric.SetUnit("1")
  dps := metric.SetEmptyGauge().DataPoints()

diff --git a/testbed/tests/metric_test.go b/testbed/tests/metric_test.go
@@ -35,7 +35,6 @@ func TestMetric10kDPS(t *testing.T) {
  ExpectedMaxCPU: 237,
  ExpectedMaxRAM: 100,
  },
- skipMessage: "Flaky test, https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/9729",
  },
  {
  name: "OpenCensus",