Skip to content

Commit

Permalink
Adapt to randomly generated nop component names in unit test (open-te…
Browse files Browse the repository at this point in the history
…lemetry#31640)

**Description:**

This should fix failures in
open-telemetry/opentelemetry-collector#9637

This unit test was relying on the ID from
`exportertest.NewNopCreateSettings` always being the same. This change
makes the test use the same create settings when storing the telemetry
registry, and when creating the trace exporter to avoid that problem.

**Link to tracking Issue:**

Blocking
open-telemetry/opentelemetry-collector#9637
  • Loading branch information
dashpole committed Mar 7, 2024
1 parent dbae3a1 commit 3853bb1
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions exporter/awsxrayexporter/awsxray_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,19 @@ func TestTelemetryEnabled(t *testing.T) {
registry := telemetry.NewRegistry()
sink := telemetrytest.NewSenderSink()
// preload the sender that the exporter will use
sender, loaded := registry.LoadOrStore(exportertest.NewNopCreateSettings().ID, sink)
set := exportertest.NewNopCreateSettings()
sender, loaded := registry.LoadOrStore(set.ID, sink)
require.False(t, loaded)
require.NotNil(t, sender)
require.Equal(t, sink, sender)
cfg := generateConfig(t)
cfg.TelemetryConfig.Enabled = true
traceExporter := initializeTracesExporter(t, cfg, registry)
traceExporter, err := newTracesExporter(cfg, set, new(awsutil.Conn), registry)
assert.NoError(t, err)
ctx := context.Background()
assert.NoError(t, traceExporter.Start(ctx, componenttest.NewNopHost()))
td := constructSpanData()
err := traceExporter.ConsumeTraces(ctx, td)
err = traceExporter.ConsumeTraces(ctx, td)
assert.Error(t, err)
err = traceExporter.Shutdown(ctx)
assert.NoError(t, err)
Expand Down

0 comments on commit 3853bb1

Please sign in to comment.