Skip to content

Commit

Permalink
[receiver/mysql] Do not export the function Query (open-telemetry#2…
Browse files Browse the repository at this point in the history
…6705)

**Link to tracking Issue:**
open-telemetry#26304

Signed-off-by: Jared Tan <[email protected]>
  • Loading branch information
JaredTan95 committed Sep 15, 2023
1 parent 32f2090 commit 1db5684
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 6 deletions.
27 changes: 27 additions & 0 deletions .chloggen/mysqlreceicer-checkapi.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: mysqlreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Do not export the function `Query`

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [26304]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
1 change: 0 additions & 1 deletion cmd/checkapi/allowlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ receiver/journaldreceiver
receiver/kafkareceiver
receiver/mongodbatlasreceiver
receiver/mongodbreceiver
receiver/mysqlreceiver
receiver/podmanreceiver
receiver/pulsarreceiver
receiver/windowseventlogreceiver
10 changes: 5 additions & 5 deletions receiver/mysqlreceiver/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,14 +205,14 @@ func (c *mySQLClient) getVersion() (string, error) {

// getGlobalStats queries the db for global status metrics.
func (c *mySQLClient) getGlobalStats() (map[string]string, error) {
query := "SHOW GLOBAL STATUS;"
return Query(*c, query)
q := "SHOW GLOBAL STATUS;"
return query(*c, q)
}

// getInnodbStats queries the db for innodb metrics.
func (c *mySQLClient) getInnodbStats() (map[string]string, error) {
query := "SELECT name, count FROM information_schema.innodb_metrics WHERE name LIKE '%buffer_pool_size%';"
return Query(*c, query)
q := "SELECT name, count FROM information_schema.innodb_metrics WHERE name LIKE '%buffer_pool_size%';"
return query(*c, q)
}

// getTableIoWaitsStats queries the db for table_io_waits metrics.
Expand Down Expand Up @@ -505,7 +505,7 @@ func (c *mySQLClient) getReplicaStatusStats() ([]ReplicaStatusStats, error) {
return stats, nil
}

func Query(c mySQLClient, query string) (map[string]string, error) {
func query(c mySQLClient, query string) (map[string]string, error) {
rows, err := c.client.Query(query)
if err != nil {
return nil, err
Expand Down

0 comments on commit 1db5684

Please sign in to comment.