Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scikit-learn version 1.4.*? #58

Closed
juhoinkinen opened this issue Feb 23, 2024 · 2 comments · Fixed by #59
Closed

Allow scikit-learn version 1.4.*? #58

juhoinkinen opened this issue Feb 23, 2024 · 2 comments · Fixed by #59
Assignees

Comments

@juhoinkinen
Copy link

Scikit-learn releases have advanced to 1.4 series.

Could you check if stwfsapy could allow upgrading to Scikit-learn 1.4.* ? Now it has pinned scikit-learn to <1.3:

scikit-learn = ">0.24,<1.3"

This would allow upgrading Scikit-learn to 1.4.* also in Annif.

@juhoinkinen
Copy link
Author

A good question is whether (minor) versions should have upper bounds at all... In Annif there has been quite constant need to sort out dependency problems:

I think this very long blog post generally says "no", but I did not read nor understand it thoroughly.

@Lakshmi-bashyam Lakshmi-bashyam self-assigned this Mar 4, 2024
Lakshmi-bashyam added a commit to Lakshmi-bashyam/stwfsapy that referenced this issue Mar 7, 2024
@Lakshmi-bashyam Lakshmi-bashyam linked a pull request Mar 8, 2024 that will close this issue
@Lakshmi-bashyam
Copy link
Contributor

Lakshmi-bashyam commented Mar 8, 2024

Thanks for sharing the blog post. I do agree with their stance on upper bounds, at least for minor version.
While it make sense to follow it now, we have to revisit in case any issues arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants