Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display_image method ignoring duration. #48

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

gimait
Copy link
Contributor

@gimait gimait commented Apr 21, 2021

The comments in #45 noted that the Client.display_image method was failing to show the image for the set duration.
Looking into the code, I saw that this happened when procedural_face_enabled was set because the AnimationController loop would start fetching new face images.

I used the playing_animation variable of AnimationController to prevent this from happening.
Now, Client.display_image starts the animation and clears the screen if a duration is set. If no duration is specified, the Client.clear_screen function should be called to stop showing the image.

It should also be noted that right now sending a new image or starting an animation will override the previously shown image, but I think this is probably the most intuitive way to work with it as well.

@gimait gimait changed the base branch from master to dev April 21, 2021 01:12
reakain added a commit to reakain/pycozmo that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants