Fix display_image method ignoring duration. #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments in #45 noted that the
Client.display_image
method was failing to show the image for the set duration.Looking into the code, I saw that this happened when
procedural_face_enabled
was set because theAnimationController
loop would start fetching new face images.I used the
playing_animation
variable ofAnimationController
to prevent this from happening.Now,
Client.display_image
starts the animation and clears the screen if a duration is set. If no duration is specified, theClient.clear_screen
function should be called to stop showing the image.It should also be noted that right now sending a new image or starting an animation will override the previously shown image, but I think this is probably the most intuitive way to work with it as well.