Use local files for testing ui.interactive_image
#3118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix our flaky pytests for
ui.interactive_image
. It seems like most failures came from fetching dummy images from a remote server, which could even block requests with a rate limit. Therefore I replaced those images with locally served copies.I also overloaded the
screen.wait_for
method to allow waiting for a condition. This is handy when waiting for events intest_loaded_event
.Furthermore I noticed a minor bug in
screen.should_not_contain
:In case
pytest.raises
itself raised, the implicit wait hasn't been set back toIMPLICIT_WAIT
. I fixed it with a try-finally block.