Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce orthographic camera for ui.scene #2890

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Introduce orthographic camera for ui.scene #2890

merged 1 commit into from
Apr 14, 2024

Conversation

falkoschindler
Copy link
Contributor

As requested in #2872, this PR introduces a parameter camera_type for ui.scene to switch between perspective and orthographic cameras.

@falkoschindler falkoschindler added the enhancement New feature or request label Apr 14, 2024
@falkoschindler falkoschindler added this to the 1.4.22 milestone Apr 14, 2024
@rodja rodja merged commit c36834a into main Apr 14, 2024
7 checks passed
@rodja rodja deleted the orthographic-scene branch April 14, 2024 11:10
@falkoschindler
Copy link
Contributor Author

I just noticed that there's no way to adjust the field of view programmatically. For perspective cameras you can simply move the camera relative to the object. But this doesn't work for orthographic cameras, which require adjusting the parameters left, right, top, and bottom.

I guess we should make these camera parameters configurable (also fov for perspective cameras). Now that this PR is merged, we can do that in another PR.

@falkoschindler falkoschindler modified the milestones: 1.4.22, 1.4.23 Apr 15, 2024
@falkoschindler
Copy link
Contributor Author

I remove this feature from 1.4.22 in order to get the API right before releasing anything. 1.4.22 will probably be a quick bugfix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants