Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More elegant way to terminate On Air connection #2761

Merged
merged 1 commit into from
Mar 25, 2024
Merged

More elegant way to terminate On Air connection #2761

merged 1 commit into from
Mar 25, 2024

Conversation

rodja
Copy link
Member

@rodja rodja commented Mar 25, 2024

This pull-request get's rid of hacky signal handler registration to terminate the On Air connection. This also fixes issues with auto-reload when On Air is active.

@rodja rodja added the enhancement New feature or request label Mar 25, 2024
@rodja rodja added this to the 1.4.20 milestone Mar 25, 2024
falkoschindler
falkoschindler approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really judge the difference, but the code looks plausible. 🤷🏻‍♂️
You can squash and merge, or we talk about it on Wednesday.

@rodja rodja merged commit ad20493 into main Mar 25, 2024
7 checks passed
@rodja rodja deleted the air-shutdown branch March 25, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkoschindler falkoschindler falkoschindler approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.20
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rodja @falkoschindler