Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jumping cursor for ui.editor #2756

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Fix jumping cursor for ui.editor #2756

merged 2 commits into from
Mar 29, 2024

Conversation

falkoschindler
Copy link
Contributor

This PR tries to solve issue #2611 by disabling loopback and disabling the "shortcut" which sets the new value directly on the client.

@falkoschindler falkoschindler added this to the 1.4.20 milestone Mar 23, 2024
@falkoschindler falkoschindler linked an issue Mar 23, 2024 that may be closed by this pull request
ui.editor cursor jumps to start of text intermittently #2611
Closed
@falkoschindler falkoschindler added the bug Something isn't working label Mar 23, 2024
@falkoschindler falkoschindler self-assigned this Mar 23, 2024
@falkoschindler falkoschindler marked this pull request as ready for review March 27, 2024 13:45
@falkoschindler
Copy link
Contributor Author

@rodja I improved the backward compatibility by switching back to a single LOOPBACK field which is now Optional. The new docstring describes its possible values. This way all value elements can remain unchanged, only the ui.editor gets LOOPBACK = None because it shouldn't receive updates from the server nor set the value prop on the client.

rodja
rodja reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@rodja rodja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Great solution.

@rodja rodja merged commit eeabc43 into main Mar 29, 2024
7 checks passed
@rodja rodja deleted the editor-loopback branch March 29, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodja rodja rodja left review comments

Assignees

@falkoschindler falkoschindler

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.20
Development

Successfully merging this pull request may close these issues.

ui.editor cursor jumps to start of text intermittently
2 participants
@falkoschindler @rodja