Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enhance macos packaging instructions #2707

Merged
merged 2 commits into from
Mar 20, 2024
Merged

docs: enhance macos packaging instructions #2707

merged 2 commits into from
Mar 20, 2024

Conversation

gotev
Copy link
Contributor

@gotev gotev commented Mar 15, 2024

No description provided.

@falkoschindler falkoschindler added the documentation Improvements or additions to documentation label Mar 18, 2024
@falkoschindler falkoschindler added this to the 1.4.19 milestone Mar 18, 2024
@falkoschindler
Copy link
Contributor

Hi @gotev, thanks for your pull request!

Just to clarify:

  1. You removed "Mac M1" from the title. We thought these instructions solve issues with Apple Silicon hardware. Do you think it also applies to Intel Macs?
  2. We added the statement about the --windowed parameter to address a specific issue some users where facing. Are you sure it really isn't needed anymore?

@falkoschindler falkoschindler added the question Further information is requested label Mar 18, 2024
@gotev
Copy link
Contributor Author

gotev commented Mar 18, 2024

@falkoschindler thanks to you and all the contributors for this amazing project!

  1. Yes, in the thread where this originated, the evidence I shared was from an Intel Mac, so the issue does not apply to only Apple Silicon Macs
  2. Without the windowed flag, pyinstaller don't produce an .app bundle, but a mere executable you can launch only from cli. Not a viable option in real world scenarios. By ensuring the freeze support statements are on top of the main python script, you can safely pass --windowed option without process spawning

Let me know if the above is sufficient or you need further information or data.

@falkoschindler falkoschindler self-requested a review March 18, 2024 17:03
@falkoschindler falkoschindler removed the question Further information is requested label Mar 18, 2024
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gotev! Sounds good to me. Let's merge! 🙂

@falkoschindler falkoschindler merged commit 319e8b0 into zauberzeug:main Mar 20, 2024
1 check passed
@gotev gotev deleted the patch-1 branch March 20, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing a packaged native app on Mac leaves processes in the background
2 participants