Add return_exclusions to runJavascript()
#2671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to potential recursion in the objects returned by runJavascript, it is necessary to remove parts of the tree without modifying the objects in place. Added an optional argument that allows the exclusion of data from the return value in a dotted-path notation.
Closed
|
Note: Might need to be formatted slightly because I couldn't get VSCode autoformatting to work and autopep8 produced different results from the CLI. |
Closed
|
Thanks for the pull request, @pikaro! The formatting is no problem. We can fix that later - if necessary. I'm a bit undecided whether the API change is worth it, or if there is another, more intuitive and/or more flexible solution to the problem. I left some more thoughts here: #2556 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to potential recursion in the objects returned by runJavascript, it is necessary to remove parts of the tree without modifying the objects in place. Added an optional argument that allows the exclusion of data from the return value in a dotted-path notation.