Add PunchDialog option for all weeding implements #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalzauberzeug
changed the title
pascalzauberzeug
force-pushed
the
punch_dialog_screw
branch
from
84d649d
to
fb67252
Compare
pascalzauberzeug
force-pushed
the
punch_dialog_screw
branch
from
aa8807a
to
fa4299a
Compare
|
The code is looking good to me. I tested the simulation with screw and straight line navigation. I am not sure about the detection. The punch dialog only opens at the beginning of the first run. When starting the automation another time it will drive the given distance without punching and showing the punch dialog. I am going to test it with a real tornado using the U4 next week. |
|
I added a check for None value in the kpi_provider, because it could not increment a None value by 1. |
LukasBaecker
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I wanted to add the PunchDialog option to the weeding screw like it was already done for the tornado, but ended up adding it for all weeding implements.
I tested the dialog for both the screw and the tornado.
I noticed that most of the time the target marker was outside of the image bounds, which is probably a calibration error.
We should run it on U4 and U6 to test both tools.