Fix YamlSyntax to specify aliases option (sds#772)

zaratan · Feb 26, 2022 · 33d4ae7 · 33d4ae7
1 parent c142cd2
commit 33d4ae7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/overcommit/hook/pre_commit/yaml_syntax.rb b/lib/overcommit/hook/pre_commit/yaml_syntax.rb
@@ -8,9 +8,13 @@ def run
 
  applicable_files.each do |file|
  begin
- YAML.load_file(file)
- rescue ArgumentError, Psych::SyntaxError => e
- messages << Overcommit::Hook::Message.new(:error, file, nil, e.message)
+ YAML.load_file(file, aliases: true)
+ rescue ArgumentError
+ begin
+ YAML.load_file(file)
+ rescue ArgumentError, Psych::SyntaxError => e
+ messages << Overcommit::Hook::Message.new(:error, file, nil, e.message)
+ end
  end
  end
 

diff --git a/spec/overcommit/hook/pre_commit/yaml_syntax_spec.rb b/spec/overcommit/hook/pre_commit/yaml_syntax_spec.rb
@@ -22,6 +22,7 @@
 
  context 'when YAML file has errors' do
  before do
+ YAML.stub(:load_file).with(staged_file, { aliases: true }).and_raise(ArgumentError)
  YAML.stub(:load_file).with(staged_file).and_raise(ArgumentError)
  end