Update egui to 0.26 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on zakarumych/egui-probe#1
zakarumych
requested changes
Feb 7, 2024
src/ui.rs
Outdated
| r.on_hover_ui_at_pointer(|ui| { | ||
| viewer.show_on_hover_popup(node, &inputs, &outputs, ui, snarl_state.scale(), self); | ||
| }); | ||
| if let Some(r) = r { |
There was a problem hiding this comment.
The r: Response is returned from r.context_menu. Semantic of the returned response changed.
Previously Response::context_menu call was consuming Response and returning it unmodified.
Now it does not consume Response and returns Option<InnerResponse> associated with context menu interaction.
So it should not be used here, the old one should.
There was a problem hiding this comment.
Sorry did not notice anything that would be not working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on zakarumych/egui-probe#1