Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dev dependencies #288

Merged
merged 4 commits into from
Jul 10, 2019
Merged

upgrade dev dependencies #288

merged 4 commits into from
Jul 10, 2019

Conversation

zakandrewking
Copy link
Owner

@zakandrewking zakandrewking commented Apr 15, 2019

  • fixes security warning with webpack-dev-server:

https://github.com/zakandrewking/escher/network/alert/package.json/webpack-dev-server/open

  • good opportunity to add peer dependencies and create an unbundled npm build
  • could also upgrade bundled dependencies, e.g. d3 libraries
  • Need to consider these new warnings:
WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/concepts/mode/

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  escher.js (1.07 MiB)
  escher.min.js (500 KiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  escher (1.07 MiB)
      escher.js
  escher.min (500 KiB)
      escher.min.js


WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/

@zakandrewking zakandrewking added this to the 1.7 milestone Jul 5, 2019
@zakandrewking zakandrewking merged commit 4fb18eb into master Jul 10, 2019
@zakandrewking zakandrewking deleted the webpack-upgrade branch July 10, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant