Sourcery refactored main branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-40
to
+42
| blank = is_blank_image(args.image_path, args.threshold, args.white_percent) | ||
|
|
||
| if blank: | ||
| if blank := is_blank_image( | ||
| args.image_path, args.threshold, args.white_percent | ||
| ): |
There was a problem hiding this comment.
Lines 40-42 refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
| colors = [] | ||
| for x, y in points: | ||
| colors.append(image[y, x]) | ||
|
|
||
| colors = [image[y, x] for x, y in points] |
There was a problem hiding this comment.
Function estimate_background_color refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension)
Comment on lines
-48
to
+47
| # compute the median angle of the lines | ||
| angles = [] | ||
| for rho, theta in lines[:, 0]: | ||
| angles.append((theta * 180) / np.pi - 90) | ||
|
|
||
| angles = [(theta * 180) / np.pi - 90 for rho, theta in lines[:, 0]] | ||
| angle = np.median(angles) | ||
|
|
There was a problem hiding this comment.
Function auto_rotate refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension)
This removes the following comments ( why? ):
# compute the median angle of the lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!