Skip to content

Commit

Permalink
Merge branch 'deadline' into 'main'
Browse files Browse the repository at this point in the history
Updates deadline for slurm clusters to avoid failures due to high capacity

See merge request ADLR/megatron-lm!1586
  • Loading branch information
terrykong committed Jun 28, 2024
2 parents b4b10ae + c72ef2b commit 7fb826e
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 9 deletions.
33 changes: 28 additions & 5 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,43 @@ variables:
DISPLAY_OUTPUT: "True" # Set to true for new tests to copy the logs for creating golden truth file
TIME_LIMIT: "10:00" # Default time limit for all jobs
MOE_GROUPED_GEMM: 0 # Set to 1 to enable grouped gemm for MoE
JET_CLUSTER_BRANCH:
value: "mcore/draco-oci"
SLURM_CLUSTER:
value: "dgxa100_dracooci"
options:
- "mcore/draco-oci"
- "mcore/eos"
description: '"mcore/draco-oci" for OCI-IAD, "mcore/eos" for EOS'
- "dgxa100_dracooci"
- "dgxh100_eos"
description: '"dgxa100_dracooci" for OCI-IAD, "dgxh100_eos" for EOS'
CI_MCORE_IMAGE: gitlab-master.nvidia.com:5005/adlr/megatron-lm/mcore_ci
CI_NEMO_IMAGE: gitlab-master.nvidia.com:5005/adlr/megatron-lm/nemo_ci
LINTING_IMAGE: gitlab-master.nvidia.com:5005/adlr/megatron-lm/mcore_linting

metadata:
image: python:3.10
stage: .pre
tags:
- 8xL40S
script:
- env
- |
if [[ $SLURM_CLUSTER == dgxh100_eos ]]; then
JET_CI_BRANCH=mcore/eos;
elif [[ $SLURM_CLUSTER == dgxa100_dracooci ]]; then
JET_CI_BRANCH=mcore/draco-oci;
else
echo "Unsupported value of SLURM_CLUSTER=$SLURM_CLUSTER";
exit 1;
fi
- echo "JET_CI_BRANCH=$JET_CI_BRANCH" | tee -a build.env
artifacts:
reports:
dotenv: build.env
interruptible: true

build_image:
tags:
- 8xL40S
image: docker:26.1.4-dind
needs: [] # May start ASAP
stage: build
timeout: 30m
parallel:
Expand Down
14 changes: 10 additions & 4 deletions jet-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,23 @@ jet-configure:
jet-trigger:
stage: jet
extends: [.jet_common, .jet-trigger]
needs: [ jet-configure, jet-setup ]
needs: [ metadata, jet-configure, jet-setup ]
trigger:
project: dl/jet/ci
branch: $JET_CLUSTER_BRANCH
branch: $JET_CI_BRANCH
strategy: depend
inherit:
variables:
- JET_CUSTOM_FILTER
- JET_CLUSTER_BRANCH
- SLURM_CLUSTER
- JET_CI_BRANCH
variables:
JET_WORKLOADS_FILTER: "$_JET_FILTER"
JET_CUSTOM_CONFIG: |
launchers:
${SLURM_CLUSTER}:
additional_flags:
deadline: now+24hours
interruptible: true

jet-results-summary:
Expand Down Expand Up @@ -98,4 +104,4 @@ jet-results-summary:
when: always
paths:
- scripts
interruptible: true
interruptible: true

0 comments on commit 7fb826e

Please sign in to comment.