Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: up triangle, point-plane distance, exact camera size #19

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

yxlao
Copy link
Owner

@yxlao yxlao commented Sep 23, 2023

Notes on API change after this PR:

disable_up_triangle=False has been replaced by up_triangle=True in the new API.

Up triangle

Now, we draw the "up triangle" by default, similar to Blender. The up direction is the negative Y direction per OpenCV convention. You may set disable_up_triangle=True to suppress drawing the up triangle.

Absolute camera scale

The camera frame now has an absolute scale, defined by the distance from the camera center to the visualized image plane. E.g., if you set the size to 1, you will get a camera frame where the distance between its camera center and the visualized image plane is 1.

Image width/height for camera plotter

Now, we support specifying image_wh when plotting camera frames. This is useful when the camera center is not exactly at the center of the image plane.

Point to plane distance

Now we can compute point-to-plane distance, where the plane is represented by 3 points. See ct.solver.point_plane_distance_three_points().

@yxlao yxlao merged commit 39bb8c3 into master Sep 23, 2023
3 checks passed
@yxlao yxlao deleted the yixing/up_triangle branch September 23, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant