Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
this is my approach to add OnlineWardleyMaps in kroki as suggested in #179
Mostly it uses the diagramsnet logic plus some help from damonsk/onlinewardleymaps#170 and damonsk/onlinewardleymaps#75
Because i cannot build the java server (some issues with jdk or other stuff), i tested it with the following docker-compose.yml and add a smoke test for this service, too.
Because the first results looks promising, i create the PR now before i try to finetune the svg/png output, because out of the box it looks not as expected.
The dockerfile contains 3 separate apps:
OnlineWardleyMaps is not created to be used in this use case, but I think my approach should handle some major cases with changes upstream. But a complete rewrite would break my approach with git diffs, so there is a git commit sha in dockerfile, which should be updated from time to time.
I am happy to hear from you and get some feedback.
TODO:
Have a great day.
Edit:
If someone wants to use this already without to wait to merge, use the following snippet in your
docker-compose.yml