Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue inferring wavedrom type from file extensions #14

Closed
albertschulz opened this issue Nov 10, 2020 · 1 comment · Fixed by #16
Closed

Issue inferring wavedrom type from file extensions #14

albertschulz opened this issue Nov 10, 2020 · 1 comment · Fixed by #16
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@albertschulz
Copy link

I guess there might be a dot missing here?

kroki-cli/cmd/convert.go

Line 249 in b802f44

case "wavedrom":

@ggrossetie
Copy link
Member

Hi @albertschulz

You are correct, nice catch!
Would you like to submit a pull request to fix this issue? You should also add a test in here to make sure that it's actually working:

kroki-cli/cmd/convert_test.go

Line 62 in b802f44

func TestGraphFormatFromFile(t *testing.T) {

Thanks!

@ggrossetie ggrossetie added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Nov 10, 2020
ggrossetie added a commit that referenced this issue Dec 22, 2020
@ggrossetie
resolves #14 correctly infer wavedrom type
cd7fa2a
@ggrossetie ggrossetie mentioned this issue Dec 22, 2020
Merged
ggrossetie added a commit that referenced this issue Dec 22, 2020
@ggrossetie
resolves #14 correctly infer wavedrom type (#16)
749d5d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #14 correctly infer wavedrom type yuzutech/kroki-cli
2 participants
@ggrossetie @albertschulz