Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom entitlements path for update_code_signing_settings function #93

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Support custom entitlements path for update_code_signing_settings function #93

merged 1 commit into from
Mar 25, 2023

Conversation

dasheck0
Copy link
Contributor

Resolves #91. Adds an option to provide entitlements_file_path to support custom setups (i.e. where each build target has a custom entitlements file).

Done:

  • Update documentation to show how to use it
  • Add parameter to action.yml and parse it as environment for fastlane to use
  • Add it to fastlane update_code_signing_settings function

@dasheck0 dasheck0 mentioned this pull request Mar 25, 2023
Closed
yukiarrr
yukiarrr approved these changes Mar 25, 2023
View reviewed changes
Copy link
Owner

@yukiarrr yukiarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response.

Thanks for your contribution!
LGTM!

@yukiarrr yukiarrr merged commit 326bb8d into yukiarrr:master Mar 25, 2023
@yukiarrr
Copy link
Owner

@dasheck0 Including this PR, v1.6.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukiarrr yukiarrr yukiarrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable custom entitlements
2 participants
@dasheck0 @yukiarrr