Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graviton support for cp commands #6

Merged
merged 6 commits into from
Feb 8, 2023

Conversation

t1732
Copy link
Contributor

@t1732 t1732 commented Feb 7, 2023

cpuArchitecture に ARM64 を指定したコンテナに対して cp を実行したく
Arm64 用にビルドした cp コマンドバイナリと --arm64 オプションの追加を追加してみました

Copy link
Owner

@yukiarrr yukiarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t1732 PRありがとうございます~!
一点コメントしたので、お手数をおかけしますが確認お願いしても良いでしょうか

pkg/cmd/cp.go Outdated Show resolved Hide resolved
Copy link
Owner

@yukiarrr yukiarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです、対応ありがとうございます~!

@yukiarrr yukiarrr merged commit 7b488a5 into yukiarrr:main Feb 8, 2023
@yukiarrr
Copy link
Owner

yukiarrr commented Feb 8, 2023

@t1732 こちらのPRを取り込み、v0.8.0としてリリースしました 🚀

@t1732 t1732 deleted the feature/cp_arm_cpu_option branch February 9, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants