Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix issue #1152] Enhance event-flick module with flickleft, flickright, flickup, flickdown sugar events #1323

Open
wants to merge 6 commits into
base: dev-3.x
Choose a base branch
from
Open

[Fix issue #1152] Enhance event-flick module with flickleft, flickright, flickup, flickdown sugar events #1323

wants to merge 6 commits into from

Commits on Oct 15, 2013

  1. event-flick: Fix issue yui#1152 

    This commit to event-flick enhances the module by adding additional
sugar events: `flickleft`, `flickright`, `flickup`, and `flickdown`.

In addition, I have broken out some of the large monolithic functions
into smaller chunks for easier testing.
    @tilomitra
    tilomitra committed Oct 15, 2013
    Configuration menu
    Copy the full SHA
    fc5700b View commit details
    Browse the repository at this point in the history

  2. event-flick: Greatly improve test coverage!

    @tilomitra
    tilomitra committed Oct 15, 2013
    Configuration menu
    Copy the full SHA
    c45766a View commit details
    Browse the repository at this point in the history

  3. event-flick: add a new manual test page

    @tilomitra
    tilomitra committed Oct 15, 2013
    Configuration menu
    Copy the full SHA
    f8886eb View commit details
    Browse the repository at this point in the history

  4. event-flick: remove trailing comma + console.log

    @tilomitra
    tilomitra committed Oct 15, 2013
    Configuration menu
    Copy the full SHA
    96c2417 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2013

  1. event-flick: Add necessary fixes as recommended by @ericf in 

    yui#1323

* Improve `processArgs()` method
* Add code comments all-round
* Separate out `_isValidFlick()` into `_isValidFlick()` and
`_isValidAxis()`. The `flick*` events over-write the latter.
    @tilomitra
    tilomitra committed Oct 16, 2013
    Configuration menu
    Copy the full SHA
    5161f19 View commit details
    Browse the repository at this point in the history

  2. event-flick: update unit tests to work with changes in 5161f19

    @tilomitra
    tilomitra committed Oct 16, 2013
    Configuration menu
    Copy the full SHA
    834a9ea View commit details
    Browse the repository at this point in the history