Update proxy.js #1254
Open
Update proxy.js #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no way to modify the cursor style on the drag node, unless the initial cursor style is set to "auto". I would like to be able to customize both the initial hovering cursor style as well as the drag cursor style. I find the whole dragCursor implementation to me clunky to begin with but at least this allows me to use the attribute when I actually want to.
|
@mikewu-x2 Looks okay to me, could you add a unit test before we merge it in? Thanks for the contribution! |
| @@ -209,7 +208,8 @@ | |||
| if (ah) { | |||
| cur = ah.getStyle('cursor'); | |||
| } | |||
| if (cur === 'auto') { | |||
|
|
|||
| if (cur === 'auto' || (cur !== 'auto' && DDM.get('dragCursor') !== 'move')) { | |||
There was a problem hiding this comment.
cur !== 'auto' is unnecessary. If the left-hand side evaluated to false, then it is implied cur is not equal to "auto".
|
@mikewu-x2 Have you had a chance to look at adding a unit test and HISTORY.md entry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to modify the cursor style on the drag node, unless the initial cursor style is set to "auto". I would like to be able to customize both the initial hovering cursor style as well as the drag cursor style.
I find the whole dragCursor implementation to me clunky to begin with but at least this allows me to use the attribute when I actually want to.
Needs: