[YoutubeDL] Merge incompatible formats into mkv (#5456)

youtube_dl/YoutubeDL.py

@@ -1373,7 +1373,29 @@ def dl(name, info):
  ' The formats won\'t be merged')
  else:
  postprocessors = [merger]
- for f in info_dict['requested_formats']:
+
+ def compatible_formats(formats):
+ video, audio = formats
+ # Check extension
+ video_ext, audio_ext = audio.get('ext'), video.get('ext')
+ if video_ext and audio_ext:
+ COMPATIBLE_EXTS = (
+ ('mp4', 'm4a', 'm4p', 'm4b', 'm4r', 'm4v'),
+ ('webm')
+ )
+ for exts in COMPATIBLE_EXTS:
+ if video_ext in exts and audio_ext in exts:
+ return True
+ # TODO: Check acodec/vcodec
+ return False
+
+ requested_formats = info_dict['requested_formats']
+ # Merge incompatible formats into mkv
+ if not compatible_formats(requested_formats):
+ filename = os.path.splitext(filename)[0] + '.mkv'
+ self.report_warning('You have requested formats uncompatible for merge. '
+ 'The formats will be merged into mkv')
+ for f in requested_formats:
  new_info = dict(info_dict)
  new_info.update(f)
  fname = self.prepare_filename(new_info)