Add GH actions workflow to check PR labels #4902
Open
+27
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like `github.ref` points to the target branch when triggered by `pull_request_target`, while `github.head_ref` is always the source branch.
|
Thank you ! As I said on slack, I'm all for migrating away from this bot (as well as the WIP bot), but we need a code owner to actually remove them. This PR should not be merge before then, let's ping @matthewturk and @Xarthisius |
chrishavlin
approved these changes
Oct 1, 2024
|
oh. hmm. mergeable is still running. oops. not sure why I thought we had disabled it :) |
|
ah, clarification from @Xarthisius : mergeable bot is still running but is no longer required for merge, which is where it was hanging. |
|
If the bot isn't blocking anymore, I'm not sure we need a replacement. I'll let you guys be the judges ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This replaces the mergeable bot, which has been flaky recently. I've tested it thoroughly at yut23#2, and it works as expected.
PR Checklist