Update FITSImageData.ipynb #1908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set width in FITSProjection.
jzuhone
requested changes
Jul 20, 2018
| @@ -79,7 +79,7 @@ | |||
| "cell_type": "markdown", | |||
| "metadata": {}, | |||
| "source": [ | |||
| "which took the same parameters as `ProjectionPlot` except the width, because `FITSProjection` and `FITSSlice` always make slices and projections of the width of the domain size, at the finest resolution available in the simulation, in a unit determined to be appropriate for the physical size of the dataset." | |||
There was a problem hiding this comment.
I think the text you deleted is fine here, but I also think that you could maybe add a quick example to this file of making the same projection with a different width, which would be clearer.
There was a problem hiding this comment.
Yes, I added a quick example, set a new pull request.
|
yes sure.
…On Mon, Jul 23, 2018 at 7:55 PM, Nathan Goldbaum ***@***.***> wrote:
Closing this in favor of #1913
<#1913>, @jzuhone
<https://github.com/jzuhone> can you take a look at that one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1908 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AVgQkEAGcN7dvx7S5EK_kateHW3MF6dbks5uJdzpgaJpZM4VYQjO>
.
|
|
Closed this in favor of PR #1913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set width in FITSProjection.
PR Summary
PR Checklist