Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BT71 entry to F1155/F1255 and fix for BT74 #153

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

svollebregt
Copy link
Contributor

The Modbusmanager from Nibe is missing this entry for the F1255, while it is included in the list of the F1145/F1245. However, you can add this sensor as AUX input in the software in the heatpump.

When tested locally with HASS with Nibe plugin and a F1255-6 running the latest firmware (R7) this sensor register is correctly read-out and displays the same value as on the heatpump.

The Modbusmanager from Nibe is missing this entry for the F1255, while it is included in the list of the F1145/F1245. However, you can add this sensor as AUX input in the software in the heatpump.

When tested locally with HASS with Nibe plugin and a F1255-6 running the latest firmware (R7) this sensor register is correctly read-out and displays the same value as on the heatpump.
If one enables the BT74 sensor as AUX input, the coil 47340 in the F-series does not decode correctly. Upon inspection, it seems that value 18 is sent, which I added to the F-series pumps. Tested locally on a F1255-6 with HA.

I do not know if it actually makes sense to change this value through HA, as the heatpump itself only allows BT74 as an option.
@svollebregt
Copy link
Contributor Author

svollebregt commented Feb 25, 2024

If one enables the BT74 sensor as AUX input, the coil 47340 in the F-series does not decode correctly. Upon inspection, it seems that value 18 is sent, which I added to the F-series pumps. Tested locally on a F1255-6 with HA.

I do not know if it actually makes sense to change this value through HA, as the heatpump itself only allows BT74 as an option.

More info: home-assistant/core#110855

@svollebregt svollebregt changed the title Add BT71 entry to F1155/F1255 Add BT71 entry to F1155/F1255 and fix for BT74 Feb 25, 2024
nibe/data/f1155_f1255.csv Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.84%. Comparing base (ec759f6) to head (cbc3d72).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   57.84%   57.84%           
=======================================
  Files          14       14           
  Lines        1243     1243           
=======================================
  Hits          719      719           
  Misses        524      524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yozik04 yozik04 merged commit 3876e70 into yozik04:master Feb 27, 2024
8 checks passed
@yozik04
Copy link
Owner

yozik04 commented Feb 27, 2024

Thank you @svollebregt and @elupus.

@elupus Do we want to make a release for it or we wait for more changes?

@elupus
Copy link
Collaborator

elupus commented Feb 27, 2024

Might as well release. There is a new beta upcoming of HA. So i can see if i can get it in.

@yozik04 yozik04 added this to the 2.9.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants