Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated S1155/S1255 data from S1155+ECS (pump fw version 2.23.4) #147

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

geekuality
Copy link
Contributor

Updated registers with missing ECS ("climate system 2") data (that is still not listed in any Nibe documentation that I could find, I originally got them by asking Nibe's Finnish service department via email).

CSV generated by the pump: modbus_addresses_all_20240119-06544323025004-1.csv

@geekuality
Copy link
Contributor Author

geekuality commented Jan 19, 2024

I wasn't quite sure how to handle registers that had different address in the source CSV vs my file directly from the pump. Decided to merge all changes and additions, so several unnamed (id:xxxx) registers' addresses were updated in CSV and in addition five named registers were changed in CSV and also changed the JSON. 🤷‍♀️

An example of changed address: https://github.com/yozik04/nibe/pull/147/files#diff-9d9d8a95e5230942a723af84ba4c7ad95225c95d9a25f88987160fe168a1d962L912-R925

@yozik04
Copy link
Owner

yozik04 commented Jan 19, 2024

Did you generate JSON or you have manually edited?

@geekuality
Copy link
Contributor Author

Generated. (While I was at it, I am just finishing another PR for improvements in extensions and the generation script. 😄 )

@yozik04
Copy link
Owner

yozik04 commented Jan 19, 2024

Do you want me to merge this one or there will be improvements?

@geekuality
Copy link
Contributor Author

Oh, this one is fine by me. :)

@geekuality
Copy link
Contributor Author

... As in, go ahead with merge. 😆

@yozik04 yozik04 merged commit e53a9ff into yozik04:master Jan 22, 2024
@yozik04
Copy link
Owner

yozik04 commented Jan 22, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants