Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tab): incorrect style #12885

Merged
merged 1 commit into from
May 28, 2024
Merged

fix(Tab): incorrect style #12885

merged 1 commit into from
May 28, 2024

Conversation

pany-ang
Copy link
Contributor

@pany-ang pany-ang commented May 27, 2024

在开启 type="card" 后,如果对 tab 进行 disabled 处理,那么 disabled 之后的 tab 项样式和正常样式并无差异。检查代码发现是因为一行 css 未生效,具体可见 commit。

<van-tabs v-model:active="active" type="card">
  <van-tab title="标签 1">内容 1</van-tab>
  <van-tab title="标签 2" disabled>内容 2</van-tab>
  <van-tab title="标签 3">内容 3</van-tab>
</van-tabs>

之前:

image

现在:

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (5cbb870) to head (5bdd359).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12885   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files         257      257           
  Lines        6957     6957           
  Branches     1711     1711           
=======================================
  Hits         6240     6240           
+ Misses        382      381    -1     
- Partials      335      336    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@chenjiahan chenjiahan merged commit 0adc41a into youzan:main May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants