Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ImagePreview): allow user to swipe to next image when the current image is moved to the edge #12666

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Mar 9, 2024

relate PR: #12660

Vertical scrolling also involves the logic when the image is moved to the edge.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 89.78%. Comparing base (2b9abfe) to head (f5465e2).

Files Patch % Lines
...ckages/vant/src/image-preview/ImagePreviewItem.tsx 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12666      +/-   ##
==========================================
- Coverage   89.85%   89.78%   -0.08%     
==========================================
  Files         257      257              
  Lines        6830     6832       +2     
  Branches     1657     1659       +2     
==========================================
- Hits         6137     6134       -3     
- Misses        368      373       +5     
  Partials      325      325              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenjiahan chenjiahan merged commit f70feab into youzan:main Mar 11, 2024
4 checks passed
@chenjiahan
Copy link
Member

Nice 😄

CatsAndMice pushed a commit to CatsAndMice/vant that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants