feat(Slider): button slot add dragging param #11946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjiahan
reviewed
Jun 10, 2023
| if (typeof index === 'number') { | ||
| const slot = slots[index === 0 ? 'left-button' : 'right-button']; | ||
| let dragIndex; |
There was a problem hiding this comment.
单滑块模式下，dragIndex 设置为 0 也可以，这样就没有 undefined 的类型了
There was a problem hiding this comment.
单滑块模式下其实不会返回 dragIndex 参数。
在双滑块模式下有个问题，用户可能需要知道当前是哪个滑块在被拖拽（只会在被拖拽的滑块上展示对应的信息）。
所以提供了 dragIndex 参数。如果当前没有拖拽行为，dragIndex 会返回 undefined。
chenjiahan
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #11943