Skip to content

Commit

Permalink
Remove prebuilt v8 support
Browse files Browse the repository at this point in the history
  • Loading branch information
piscisaureus authored and ry committed Dec 18, 2018
1 parent 0481d6c commit b403268
Show file tree
Hide file tree
Showing 11 changed files with 3 additions and 135 deletions.
11 changes: 0 additions & 11 deletions Docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -387,17 +387,6 @@ We use Flatbuffers to define common structs and enums between TypeScript and
Rust. These common data structures are defined in
https://github.com/denoland/deno/blob/master/src/msg.fbs

### Internal: Updating prebuilt binaries

V8 takes a long time to build - on the order of an hour. We use pre-built V8
libraries stored in a Google Storage bucket instead of rebuilding it from
scratch each time. Our build system is however setup such that we can build V8
as part of the Deno build if necessary (useful for debugging or changing various
configurations in V8, or building the pre-built binaries themselves). To control
whether to use a pre-built V8 or not use the `use_v8_prebuilt` GN argument.

Use `tools/gcloud_upload.py` to upload new prebuilt files.

## Contributing

See
Expand Down
25 changes: 3 additions & 22 deletions libdeno/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -41,28 +41,9 @@ v8_static_library("libdeno") {
"file_util.h",
"internal.h",
]
if (!use_prebuilt_v8) {
public_deps = [
":v8",
]
} else {
# TODO(ry) It would be nice to have a standalone target for the prebuilt
# library that could simply be added to the deps here, but it wasn't
# obvious how to accomplish that in gn.
if (is_mac) {
libs = [ "//prebuilt/mac/libv8.a" ]
} else if (is_linux) {
libs = [ "//prebuilt/linux64/libv8.a" ]
} else if (is_win) {
if (is_debug) {
libs = [ "//prebuilt/win/v8_debug.lib" ]
} else {
libs = [ "//prebuilt/win/v8.lib" ]
}
} else {
assert(false, "We don't have prebuilt binaries for this platform yet.")
}
}
public_deps = [
":v8",
]
}

v8_executable("snapshot_creator") {
Expand Down
5 changes: 0 additions & 5 deletions libdeno/deno.gni
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
# Copyright 2018 the Deno authors. All rights reserved. MIT license.
import("//build/compiled_action.gni")

declare_args() {
# Use prebuilt V8 libraries from //prebuilt/
use_prebuilt_v8 = true
}

template("run_node") {
action(target_name) {
forward_variables_from(invoker, "*")
Expand Down
2 changes: 0 additions & 2 deletions prebuilt/.gitignore

This file was deleted.

1 change: 0 additions & 1 deletion prebuilt/linux64/libv8.a.sha1

This file was deleted.

1 change: 0 additions & 1 deletion prebuilt/mac/libv8.a.sha1

This file was deleted.

1 change: 0 additions & 1 deletion prebuilt/win/v8.lib.sha1

This file was deleted.

1 change: 0 additions & 1 deletion prebuilt/win/v8_debug.lib.sha1

This file was deleted.

54 changes: 0 additions & 54 deletions tools/gcloud_upload.py

This file was deleted.

35 changes: 0 additions & 35 deletions tools/prebuilt.py

This file was deleted.

2 changes: 0 additions & 2 deletions tools/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import re
import sys
from distutils.spawn import find_executable
import prebuilt


def main():
Expand All @@ -19,7 +18,6 @@ def main():
third_party.download_gn()
third_party.download_clang_format()
third_party.download_clang()
prebuilt.load()
third_party.maybe_download_sysroot()

write_lastchange()
Expand Down

0 comments on commit b403268

Please sign in to comment.