Skip to content

Commit

Permalink
build: fix mac linking problem
Browse files Browse the repository at this point in the history
  • Loading branch information
piscisaureus committed Dec 20, 2018
1 parent c531b0c commit 9e70b0d
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
2 changes: 1 addition & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ group("deno_deps") {
deps = [
":msg_rs",
":snapshot_deno",
"libdeno:libdeno",
"libdeno:libdeno_static_lib",
]
}

Expand Down
16 changes: 12 additions & 4 deletions libdeno/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,20 @@ config("deno_config") {
}

v8_source_set("v8") {
configs = [ ":deno_config" ]
deps = [
"//third_party/v8:v8",
"//third_party/v8:v8_libbase",
"//third_party/v8:v8_libplatform",
"//third_party/v8:v8_libsampler",
]
configs = [ ":deno_config" ]
}

# Only functionality needed for libdeno_test and snapshot_creator
# In particular no flatbuffers, no assets, no rust, no msg handlers.
# Because snapshots are slow, it's important that snapshot_creator's
# dependencies are minimal.
# The cargo-driven build links with libdeno to pull in all non-rust code.
v8_static_library("libdeno") {
configs = [ ":deno_config" ]
v8_source_set("libdeno") {
sources = [
"api.cc",
"binding.cc",
Expand All @@ -52,8 +50,18 @@ v8_static_library("libdeno") {
]
deps = [
":v8",
]
configs = [ ":deno_config" ]
}

# The cargo-driven build links with libdeno to pull in all non-rust code.
v8_static_library("libdeno_static_lib") {
output_name = "libdeno"
deps = [
":libdeno",
"//build/config:shared_library_deps",
]
configs = [ ":deno_config" ]
}

v8_executable("snapshot_creator") {
Expand Down

0 comments on commit 9e70b0d

Please sign in to comment.