Bugfix/SimulateLocation Fix #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gemma Barlow <[email protected]>
…/XcodeGen into feature/StoreKitConfiguration
jcolicchio
force-pushed
the
bugfix/SimulateLocationFix
branch
from
7f77413
to
fb72d87
Compare
|
Happy to review this @jcolicchio if you could merge master in so the PR diff can be seen |
|
@yonaskolb Thanks! I've just merged 👍 |
yonaskolb
reviewed
Feb 15, 2021
Docs/ProjectSpec.md
Outdated
| @@ -776,7 +776,7 @@ The different actions share some properties: | |||
| - [ ] **language**: **String** - `run` and `test` actions can define a language that is used for Application Language | |||
| - [ ] **region**: **String** - `run` and `test` actions can define a language that is used for Application Region | |||
| - [ ] **debugEnabled**: **Bool** - `run` and `test` actions can define a whether debugger should be used. This defaults to true. | |||
| - [ ] **simulateLocation**: **[Simulate Location](#simulate-location)** - `run` action can define a simulated location | |||
| - [ ] **simulateLocation**: **[Simulate Location](#simulate-location)** - `run` action can define a simulated location. See [Options](#options). | |||
There was a problem hiding this comment.
Could you add a note down in Simulate Location that it will use schemePathPrefix. Also not sure what this See Options refers to?
There was a problem hiding this comment.
Good thinking! I meant to refer to schemePathPrefix within Options, but putting it in the Simulate Location section makes more sense
jcolicchio
force-pushed
the
bugfix/SimulateLocationFix
branch
from
c1f2078
to
bbdc2ac
Compare
jcolicchio
force-pushed
the
bugfix/SimulateLocationFix
branch
from
bbdc2ac
to
3133c8e
Compare
yonaskolb
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggybacking off of the
schemePathPrefixapproach introduced inStoreKitConfiguration, this PR causesSimulateLocationto use theschemePathPrefixoption, to adjust for.xcworkspaceusage. This changes the defaultSimulateLocationidentifier prefix for.xcodeprojusage from../to../../. Fixes issue #965