Allow copying of resource files from targets #95
Conversation
|
Nice catch @keith! |
Previously we were assuming that all targets that were not app extensions should be added to the copy frameworks build phase, even though we didn't have any guarantee they were actually frameworks. This updates that to ensure that things copied in the copy frameworks phase are actually frameworks, and then falls back to the resources phase instead. This fixes the ability to embed bundle targets, and copy them as resources.
|
Thanks! Rebased |
| @@ -261,10 +262,12 @@ public class PBXProjGenerator { | |||
| if dependencyTarget.type.isExtension { | |||
| // embed app extension | |||
| extensions.append(embedFile.reference) | |||
| } else if dependencyTarget.type.isFramework { | |||
There was a problem hiding this comment.
We'd need a bit more check here since the extension is not the only one determining if the framework needs to be copied. Only the dynamic ones need to. You can use lipo for that.
There was a problem hiding this comment.
Yea, I thought about that case, we actually have that case and I'm currently setting embed: False on it since we don't currently have a reference to the actual binary.
There was a problem hiding this comment.
We can also use file which might be easier than lipo for this
There was a problem hiding this comment.
I thought this was at least an improvement since that's now the only case we're not handling correctly after this and my other PRs
There was a problem hiding this comment.
I agree this could be the second iteration to make it more concrete 👍. I didn't know it was possible to get that info using file.
Previously we were assuming that all targets that were not app
extensions should be added to the copy frameworks build phase, even
though we didn't have any guarantee they were actually frameworks. This
updates that to ensure that things copied in the copy frameworks phase
are actually frameworks, and then falls back to the resources phase
instead. This fixes the ability to embed bundle targets, and copy them
as resources.
Fixes #91