Add scheme actions to build step for TargetScheme #823
Conversation
|
@brentleyjones this is interesting. Wouldn't this mean an action would run twice? Once on build and then once in the action someone is launching. If so one could argue this should happen on everything except build, or just build |
|
I agree, I found this bug because I wanted it to run on build, but not the others. I submitted the fix based on the description. Ideally it would be build only. |
|
Out of interest what breaks when the script is run on the active step and not build? Also as a note, the documentation is referring to all build phases instead of all launch types
|
|
When you build a static library, it doesn't have a "run" action, you have to use "build". We are trying to collect build statistics that require scripts to be run before and after a build, and it doesn't work for static libraries right now.
If people were doing something non-build related. I can't think of what one would want to do here, but: https://xkcd.com/1172/ |
|
Haha, I was actually thinking about that XKCD comic! |
Adjusts the preActions and postActions of a TargetScheme to only be applied applied to the `build` step.
brentleyjones
force-pushed
the
build-scheme-pre-post-actions
branch
from
2a208c1
to
f62bd59
Compare
|
@yonaskolb Done! |
We say in the documentation that the preActions and postActions of a TargetScheme are applied to all steps. They weren't being applied to the build step though.