Added static framework build settings presets #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also may solve #813 |
yonaskolb
requested changes
Apr 2, 2020
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| #### Fixed | |||
| - Fixed issue which caused watch app schemes to be generated incorrectly, preventing these apps from launching. [#798](https://github.com/yonaskolb/XcodeGen/pull/798) @daltonclaybrook | |||
| - Added build presets for the target type `framework.static`: due to the lack of them, archiving a static framework was resulting in an invalid archive. See https://github.com/yonaskolb/XcodeGen/pull/358 and https://stackoverflow.com/a/26563115/3203441 for further references. [#819](https://github.com/yonaskolb/XcodeGen/pull/819) @acecilia | |||
There was a problem hiding this comment.
The context here is great! We can leave it in this PR though
There was a problem hiding this comment.
Context removed from CHANGELOG.md👌
…LL: 'YES' was resulting in invalid archives when archiving. See yonaskolb#358 and https://stackoverflow.com/a/26563115/3203441 for further references
yonaskolb
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added static framework build settings presets: the lack of
SKIP_INSTALL: 'YES'was resulting in invalid archives when archiving. See #358 and https://stackoverflow.com/a/26563115/3203441 for further references