Add Test Plans #716

yonaskolb · 2019-11-10T03:58:39Z

Adds test plan support
Resolves #684

Possible changes:

make top level testPlans which are then referenced in schemes, similar to the new projectReferences?
ability to choose a default test plan? At the moment the first test plan in a scheme will be the default
ability to define test plans in the spec itself? If not we probably need a way to update the UUIDs in existing files in case XcodeGen/XcodeProj ever changes them

yonaskolb · 2019-11-10T04:26:45Z

Sources/ProjectSpec/Scheme.swift

+
+ static var pathProperties: [PathProperty] {
+ [
+ .string("testPlans")


This file is getting large, gonna split it up

giginet

LGTM

giginet · 2019-11-10T13:44:50Z

Sources/XcodeGenKit/SchemeGenerator.swift

@@ -194,10 +194,18 @@ public class SchemeGenerator {
 let launchVariables = scheme.run.flatMap { $0.environmentVariables.isEmpty ? nil : $0.environmentVariables }
 let profileVariables = scheme.profile.flatMap { $0.environmentVariables.isEmpty ? nil : $0.environmentVariables }

+ var testPlans: [XCScheme.TestPlanReference]?


You can use let

let testPlanns: [XCScheme.TestPlanReference]? = scheme.test?.testPlans.map { plans in return plans.enumerated().map { index, path in .init(reference: "container:\(path)", default: index == 0) } }

Yeah there’s a few ways to do it. The property has to be nil if there are no test plans though, as that’s what XcodeProj expects

Points of my comment was avoiding using mutable variables as we can.
Type should be [XCScheme.TestPlanReference]? Sorry.

min · 2020-01-22T23:14:39Z

@yonaskolb any updates on release for this? would love to start migrating to test plans.

armintelker · 2020-03-01T09:33:41Z

I really like to use XcodeGen but our project is build up on test plans. Is here any update.

soffes · 2020-03-21T04:57:09Z

Really looking forward to this! Thanks for your effort on this feature! <3

pinda · 2020-04-21T13:47:00Z

Looking forward to this! Any ETA on when this will become available?

omares · 2020-04-24T10:44:07Z

hey @yonaskolb / @giginet is there anything one can do to help out finializing this? I would like to give it a try and pick this up.

omares · 2020-04-24T14:34:30Z

Went ahead and created an up-to-date version of the branch, tried my best to resolve the conflicts, but i really need some hints what the actual code was lacking. :D

Edit 1: Started with the simplest one: Adding documentation

Edit 2: Guess I understand the to-dos now. First up ill add the option to define a default test plan, after that ill try to add spec validation.

omares · 2020-04-24T20:43:40Z

I created a draft PR #846 that contains the default test plan option, validation errors + tests and the updated documentation. It only lacks the uuid update, would love to hear hints on how to tackle that. I would suggest taking further discussions, on how to proceed to the new PR.

popwarfour · 2021-02-12T17:16:17Z

Would love this feature!

Almaz5200 · 2021-12-27T13:54:34Z

Hi! Any updates on when this PR is going to be merged?

SentoCrespo · 2022-03-29T07:20:13Z

+1 to test plans!

DmitryShapovalov · 2022-03-29T07:29:11Z

also, +1 for test plans!

SentoCrespo · 2022-03-30T09:21:29Z

Just in case you missed this, I won't spam anymore, promised :D

@giginet
@kateinoigakukun
@ryohey

SarannyaSalim · 2022-04-19T12:07:44Z

+1 to test plans

rublagar · 2022-04-19T13:22:59Z

+1 to test plans

hakkurishian · 2022-05-07T09:47:28Z

+++++++1 :)

# Conflicts: # Sources/ProjectSpec/Scheme.swift # Sources/XcodeGenKit/SourceGenerator.swift # Tests/Fixtures/SPM/SPM.xcodeproj/project.pbxproj # Tests/Fixtures/SPM/SPM.xcodeproj/xcshareddata/xcschemes/App.xcscheme # Tests/Fixtures/TestProject/Project.xcodeproj/project.pbxproj # Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/App_Scheme.xcscheme # Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/App_iOS Production.xcscheme # Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/App_iOS Staging.xcscheme # Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/App_iOS Test.xcscheme # Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/App_macOS.xcscheme # Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/App_watchOS.xcscheme # Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/Framework.xcscheme # Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/Tool.xcscheme # Tests/Fixtures/TestProject/Project.xcodeproj/xcshareddata/xcschemes/iMessageApp.xcscheme # Tests/Fixtures/TestProject/project.yml # Tests/ProjectSpecTests/SpecLoadingTests.swift # Tests/XcodeGenKitTests/SchemeGeneratorTests.swift

# Conflicts: # Sources/ProjectSpec/Scheme.swift # Tests/Fixtures/paths_test/included_paths_test.yml # Tests/ProjectSpecTests/SpecLoadingTests.swift

# Conflicts: # Tests/ProjectSpecTests/ProjectSpecTests.swift

# Conflicts: # Sources/ProjectSpec/FileType.swift

yonaskolb · 2022-05-09T12:09:15Z

Ok, have found some time to pick this up! I've pulled in changes from #846 and also made some further additions.
This is now at a point where it's usable with some big caveats for now. As the docs now say:

For now test plans are not generated by XcodeGen and must be created in Xcode and checked in, and then referenced by path. If the test targets are added, removed or renamed, the test plans may need to be updated in Xcode.

I hope this is useable in its current state for some people. The plan is to release this in the next version.

In terms of fully specced and generated test plans that is a whole bunch more work:

Support for these types of files in XcodeProj Add support for test plans tuist/XcodeProj#484
The addition of Test Plans in the project spec. The test plan file format is also expected to be a configuration file that changes often with Xcode releases making the spec hard to keep up to date.

yonaskolb · 2022-05-10T05:10:55Z

Released in 2.29.0

yonaskolb requested review from kateinoigakukun, ryohey, brentleyjones and giginet November 10, 2019 03:59

yonaskolb commented Nov 10, 2019

View reviewed changes

giginet approved these changes Nov 10, 2019

View reviewed changes

yonaskolb added 6 commits January 15, 2020 23:34

upgrade scheme and project versions

68977fa

parse test plans

b52f53c

remove xctestplan from resources

66a9225

generate test plan references in schemes

dd681a7

add test plan to fixture

54fd00e

non-mutable way of creating [XCScheme.TestPlanReference]

1114a40

yonaskolb force-pushed the test_plans branch from cb90212 to 1114a40 Compare January 15, 2020 12:37

update fixture version

85a8dad

omares mentioned this pull request Apr 24, 2020

Test plans continued #846

Closed

11 tasks

brentleyjones removed their request for review January 6, 2021 14:28

yonaskolb and others added 11 commits May 9, 2022 20:37

Add documentation

ece6d7b

Add default test plan option

739b785

# Conflicts: # Sources/ProjectSpec/Scheme.swift # Tests/Fixtures/paths_test/included_paths_test.yml # Tests/ProjectSpecTests/SpecLoadingTests.swift

Add test plan validation

8abbaea

# Conflicts: # Tests/ProjectSpecTests/ProjectSpecTests.swift

Check for multiple default test plans

afa3194

set first plan as default default plan

3898bec

small tweaks

8c3857e

fix test plan path properties

359d2b6

add test plants to target scheme

8ae6323

docs

c389fe4

Merge branch 'master' into test_plans

791f600

# Conflicts: # Sources/ProjectSpec/FileType.swift

yonaskolb added 3 commits May 9, 2022 22:12

fix fixture test plan path

9df76aa

update changelog

ed93fd5

added ability to disable test plan path validation

a4c3f3f

yonaskolb merged commit e35f7df into master May 10, 2022

yonaskolb deleted the test_plans branch May 10, 2022 03:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Test Plans #716

Add Test Plans #716

yonaskolb commented Nov 10, 2019 •

edited

Loading

yonaskolb Nov 10, 2019

giginet left a comment

giginet Nov 10, 2019 •

edited

Loading

yonaskolb Nov 10, 2019

giginet Nov 11, 2019

min commented Jan 22, 2020

armintelker commented Mar 1, 2020

soffes commented Mar 21, 2020

pinda commented Apr 21, 2020

omares commented Apr 24, 2020

omares commented Apr 24, 2020 •

edited

Loading

omares commented Apr 24, 2020 •

edited

Loading

popwarfour commented Feb 12, 2021

Almaz5200 commented Dec 27, 2021

SentoCrespo commented Mar 29, 2022

DmitryShapovalov commented Mar 29, 2022 •

edited

Loading

SentoCrespo commented Mar 30, 2022

SarannyaSalim commented Apr 19, 2022

rublagar commented Apr 19, 2022

hakkurishian commented May 7, 2022

yonaskolb commented May 9, 2022

yonaskolb commented May 10, 2022

Add Test Plans #716

Add Test Plans #716

Conversation

yonaskolb commented Nov 10, 2019 • edited Loading

yonaskolb Nov 10, 2019

Choose a reason for hiding this comment

giginet left a comment

Choose a reason for hiding this comment

giginet Nov 10, 2019 • edited Loading

Choose a reason for hiding this comment

yonaskolb Nov 10, 2019

Choose a reason for hiding this comment

giginet Nov 11, 2019

Choose a reason for hiding this comment

min commented Jan 22, 2020

armintelker commented Mar 1, 2020

soffes commented Mar 21, 2020

pinda commented Apr 21, 2020

omares commented Apr 24, 2020

omares commented Apr 24, 2020 • edited Loading

omares commented Apr 24, 2020 • edited Loading

popwarfour commented Feb 12, 2021

Almaz5200 commented Dec 27, 2021

SentoCrespo commented Mar 29, 2022

DmitryShapovalov commented Mar 29, 2022 • edited Loading

SentoCrespo commented Mar 30, 2022

SarannyaSalim commented Apr 19, 2022

rublagar commented Apr 19, 2022

hakkurishian commented May 7, 2022

yonaskolb commented May 9, 2022

yonaskolb commented May 10, 2022

yonaskolb commented Nov 10, 2019 •

edited

Loading

giginet Nov 10, 2019 •

edited

Loading

omares commented Apr 24, 2020 •

edited

Loading

omares commented Apr 24, 2020 •

edited

Loading

DmitryShapovalov commented Mar 29, 2022 •

edited

Loading